GSI Forum
GSI Helmholtzzentrum für Schwerionenforschung

Home » PANDA » PandaRoot » Tracking » Global Problems
Re: Global Problems [message #10084 is a reply to message #10075] Wed, 03 February 2010 14:12 Go to previous messageGo to previous message
Radoslaw Karabowicz is currently offline  Radoslaw Karabowicz
Messages: 108
Registered: June 2004
Location: GSI
continuous participant
From: *gsi.de
I would really like to solve the issue with PndDetectorList.h before the next evo meeting in a week;)

From what I see now in the file, the fDetectorType enumerates different type of data, that are stored in different TClonesArray (like in case of MVD) to be used at a later stage (for example in GFRecoHitFactory).

Basing on this, I will probably add another values there: kGemDigi, kDchPoint, kDchDigi, kDchHit. But even without this change the name "fDetectorType" is a bit misleading. It should be rather "DataType" or something like this. The other problems I see are purely aesthetic:
a/ the enum is growing too large, too detailed and too complicated
b/ can't we really follow one naming scheme? This is the old old old story, but checking each time wether one decided to write GEM or Gem, MC or Mc, ID or Id, getX or GetX is horribly annoying.

yours
radek
 
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Previous Topic: Restructuring of Tracking Code
Next Topic: Genfit Reco Hits
Goto Forum:
  


Current Time: Wed Jul 24 00:02:28 CEST 2024

Total time taken to generate the page: 0.00868 seconds