GSI Forum
GSI Helmholtzzentrum für Schwerionenforschung

Home » PANDA » PandaRoot » Bugs, Fixes, Releases » PRGFitter
PRGFitter [message #15473] Mon, 09 September 2013 19:54 Go to next message
Simon Reiter is currently offline  Simon Reiter
Messages: 44
Registered: May 2013
continuous participant
From: *wlan.uni-giessen.de
Hi everybody,

while plotting some stuff, I scanned some results from the PndVtxPRG fitter.
I recognized the error in the release, but I could also confirm it in the trunk. Since the release won't be fixed, I guess, I will not consider it anymore.
I reconstruct D mesons and do the fit as follows:
PndVtxPRG prgfitter(d0[i]);
TVector3 vertD;
vertD.SetXYZ(0,0,0);
prgfitter.Fit();
Float_t chi2s=prgfitter.GetChi2();
vertD=d0[i]->GetFit()->Daughter(0)->GetPosition();
Float_t vertDrho=vertD.Mag();

I write the chi2s and vertDrho in a tuple. I was wondering, that for chi2s, I get in some events -20 while the vertDrho is set to nan.
Any ideas?
BTW: In the release, both was set to nan.

Best regards
Simon

PS: the trunk folder was updated this morning.
Re: PRGFitter [message #15474 is a reply to message #15473] Mon, 09 September 2013 20:18 Go to previous messageGo to next message
Ralf Kliemt is currently offline  Ralf Kliemt
Messages: 507
Registered: May 2007
Location: GSI, Darmstadt
first-grade participant

From: *pool.mediaWays.net
Hello Simon.

Please filter out these not converging fits which give the chi2=-20.

Cheers
Ralf
Re: PRGFitter [message #15477 is a reply to message #15474] Tue, 10 September 2013 23:38 Go to previous messageGo to next message
StefanoSpataro is currently offline  StefanoSpataro
Messages: 2736
Registered: June 2005
Location: Torino
first-grade participant

From: *dip0.t-ipconnect.de
Maybe the all Fit functions should return a boolean telling if the fit failed or not.
I.e.

Bool_t isGood = prgfitter.Fit();
if (isGood) ....
else ...


instead of being void. What do you think, Ralf?
Re: PRGFitter [message #15478 is a reply to message #15473] Wed, 11 September 2013 07:42 Go to previous messageGo to next message
Ralf Kliemt is currently offline  Ralf Kliemt
Messages: 507
Registered: May 2007
Location: GSI, Darmstadt
first-grade participant

From: *pool.mediaWays.net
Basically yes.
I have to see if there was a reason why I didn't put it in the first place besides the old Rho heriatage....

Ralf
Re: PRGFitter [message #15483 is a reply to message #15473] Wed, 11 September 2013 16:33 Go to previous message
Ralf Kliemt is currently offline  Ralf Kliemt
Messages: 507
Registered: May 2007
Location: GSI, Darmstadt
first-grade participant

From: *pool.mediaWays.net
Hello again.

I put the bool status flag. Be aware that only few cases of failure are covered. Errors by not inverted matrices are not caught by the algorithms.

Ralf
Previous Topic: [FIXED] compilation problem with PndHyp.h at trunk
Next Topic: [FIXED] Bug in PndEmcAsicPulseshape ?
Goto Forum:
  


Current Time: Tue Jul 23 22:26:34 CEST 2024

Total time taken to generate the page: 0.00693 seconds