GSI Forum
GSI Helmholtzzentrum für Schwerionenforschung

Home » PANDA » PandaRoot » Bugs, Fixes, Releases » TPC MVD and GEM correlators
TPC MVD and GEM correlators [message #12013] Thu, 16 June 2011 02:30 Go to next message
Felix Boehmer is currently offline  Felix Boehmer
Messages: 149
Registered: May 2007
Location: Munich
first-grade participant

From: *gsi.de
Hi all,

I checked in correlator tasks for MVD and GEM in tpc/tpcreco. Also, there is a testing macro: macro/run/tdrct/run_reco_tpc.C

The scheme is easy: First comes real TPC PR, the fit, then the MVD correlator, another fit, then the correlation with the GEM and the final fit.

Please go ahead and try.


One observation, though: I still have trouble with GEANE, especially when extrapolating in forward direction into the GEMs (floating point exceptions). I can't do anything about it right now. There is an option in the PR (useGeane()) which is the default in the macro. By disabling it, the track representation will change to RKTrackRep, which shows no such problems, but seems to have inferior material effect calculations.

So please try the stability of the channel in question first.
Also, I would be helpful if people start using the macro also off the grid in private small runs and share their experience with me.

Be sure to update your

tpc/tpcreco
GenfitTools
genfit
recotaks
macro

folders to have the lates reconstruction algorithms in place.

Cheers

Felix
Re: TPC MVD and GEM correlators [message #12015 is a reply to message #12013] Thu, 16 June 2011 13:05 Go to previous messageGo to next message
Dima Melnychuk is currently offline  Dima Melnychuk
Messages: 213
Registered: April 2004
Location: National Centre for Nucle...
first-grade participant
From: *fuw.edu.pl
Hi Felix,

I tried TPC reconstruction macro (I adapted it as run_reco_tpc_evt.C in /macro/run/tdtct/eta_c/)

run_sim_tpc_evt.C
run_digi_tpc_evt.C
run_reco_tpc_evt.C

and immediately have the following crash from the KalmanTask:

Toggle Spoiler


From the log it looks like it's the first event and third call of KalmanTask, i.e. after PndTpcGEMCorrelatorTask.

And I have to admit that numerous messages from the floating point exceptions
----------------------------------------------------
GFException thrown with excString:
GEANE propagation failed
in line: 306 in file: /home/dimam/pandaroot/pandaroot/GenfitTools/trackrep/GeaneTrackRep/Geane TrackRep.cxx
with fatal flag 0
ABORT
----------------------------------------------------

seriously complicates reading the log, but Felix mentioned them already.

Dima
Re: TPC MVD and GEM correlators [message #12016 is a reply to message #12013] Thu, 16 June 2011 13:15 Go to previous messageGo to next message
StefanoSpataro is currently offline  StefanoSpataro
Messages: 2736
Registered: June 2005
Location: Torino
first-grade participant

From: *to.infn.it
Hi,
I have just run the new macro/run/tdrct/run_tpc_reco.C macro.
First I have run 50 evtgen events, after digitization, and after reco:

root -l run_sim_tpc_evt.C"(50)"
root -l run_digi_tpc_evt.C
root -l run_reco_tpc.C


(of course I have edited the input file names in the reco).

At the end of the first event I have the following crash:

GFAbsTrackRep::chi^2
1543.
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
starting track3
GFException thrown with excString:
GFRecoHitFactory: no hitProducer for this detID available
in line: 61 in file: /home/spataro/may11/may11/genfit/GFRecoHitFactory.cxx
with fatal flag 0

GFException Info Output
===========================
Numbers Label String:
detID
---------------------------
Numbers:
24.00
===========================
Error: Symbol #include is not defined in current scope  run_reco_tpc.C:141:
Error: Symbol exception is not defined in current scope  run_reco_tpc.C:141:
Syntax Error: #include <exception> run_reco_tpc.C:141:
Error: Symbol G__exception is not defined in current scope  run_reco_tpc.C:141:
Error: type G__exception not defined FILE:/home/spataro/may11/may11/macro/run/tdrct/./run_reco_tpc.C LINE:141
*** Interpreter error recovered ***
root [1]


If I comment out the last kalmantask I have no crash anymore (at least with 50 events).
Could you please check? I suppose there is some not caught exception in the KalmanTask.

I have several comments about the new reco macro:
  1. Ca we move the tpc clusterization to the digi macro, or remove it in the digi? At present we are running the same code, even if with different parameters, twice
  2. I suppose you do not need the mvdriemann code for the tpc+mvd tracking, unlike the stt case. Isn't it? (just to be sure)
  3. You are running tpc tracking, and after kalman, then tpc+mvd, and kalman, tpc+mvd+gem, and kalman. Would it be much faster to run tpc tpc+mvd and tpc+mvd+gem only with the prefit values, and to run only a final kalman at the end? This would save a lot of time, a lot of crashes and memory usage, and I suppose in the prefit phase we do not need to "kalmanize" the tracks but only at the end for the fina parameters
  4. Which particle hypothesis are you using for the kalman?
  5. Is there a way to reduce all those messages? They make the log output file large
  6. I would strongly suggest to use the GenfitTools/recotask/PndRecoKalmanTask-Fit (as I have already told to Sebastian when he came back into the business, almost one month ago), because it is in the standard way and return directly a PndTrack object from another PndTrack object. Probably KalmanTask and PndRecoKalmanTask/Fit should just be compared, they are doing the same things but with different output. The main problem is that, if we run the KalmanTask, we have also to write a new task converting the GFTrack into PndTrack, while this job is already done in the PndRecoKalmanFit code. The PndTrack object is the starting point of the correlator to produce our TCandidate, without PndTrack users cannot run analysis


Of course I will help for the coding, at least for the common parts.


[Updated on: Thu, 16 June 2011 13:22]

Report message to a moderator

Re: TPC MVD and GEM correlators [message #12018 is a reply to message #12015] Thu, 16 June 2011 14:39 Go to previous messageGo to next message
Felix Boehmer is currently offline  Felix Boehmer
Messages: 149
Registered: May 2007
Location: Munich
first-grade participant

From: *gsi.de
Hi Dima,

this is one of the dreaded GEANE floating point exceptions Imentrioned. I am trying to get to the bottom of this with Lias help today.

Until then I recommend turning off GEANE in the macro as I explained.

Cheers

Felix
Re: TPC MVD and GEM correlators [message #12019 is a reply to message #12016] Thu, 16 June 2011 14:52 Go to previous messageGo to next message
Felix Boehmer is currently offline  Felix Boehmer
Messages: 149
Registered: May 2007
Location: Munich
first-grade participant

From: *gsi.de
Hi Stefano,

do you have the latest version of the KalmanTask? It looks like you don't and there is one of the RecoHitProducers not properly defined.

To your questions:

Quote:


Ca we move the tpc clusterization to the digi macro, or remove it in the digi? At present we are running the same code, even if with different parameters, twice

I removed the clustering from the reco macro.

Quote:

I suppose you do not need the mvdriemann code for the tpc+mvd tracking, unlike the stt case. Isn't it? (just to be sure)

You are right, I don't.

Quote:

You are running tpc tracking, and after kalman, then tpc+mvd, and kalman, tpc+mvd+gem, and kalman. Would it be much faster to run tpc tpc+mvd and tpc+mvd+gem only with the prefit values, and to run only a final kalman at the end? This would save a lot of time, a lot of crashes and memory usage, and I suppose in the prefit phase we do not need to "kalmanize" the tracks but only at the end for the fina parameters

What you describe was my first approach. However, using the MVD hits after TPC+MVD correlation in a fit gives better results for the (possibly very long) extrapolation into the GEMs. I would keep it that way. I agree that it is slow, but it is the best I have right now. The crashes are completely isoloated to GEANE extrapolations into the GEMs as far as I can tell right now... I am working on it, as I said.

Quote:

Which particle hypothesis are you using for the kalman?
Is there a way to reduce all those messages? They make the log output file large

The particle hypothesis is obtained from MC information isndie the PndTpcRiemannTrackingTask. I can build in a setter if you want to have manual control during the reco.


Quote:

I would strongly suggest to use the GenfitTools/recotask/PndRecoKalmanTask-Fit (as I have already told to Sebastian when he came back into the business, almost one month ago), because it is in the standard way and return directly a PndTrack object from another PndTrack object. Probably KalmanTask and PndRecoKalmanTask/Fit should just be compared, they are doing the same things but with different output. The main problem is that, if we run the KalmanTask, we have also to write a new task converting the GFTrack into PndTrack, while this job is already done in the PndRecoKalmanFit code. The PndTrack object is the starting point of the correlator to produce our TCandidate, without PndTrack users cannot run analysis

I can take a look at this after I have fixed all the other, more urgent problem. I would be very grateful if you could have a lokk at this. Probably the exchange would be a very technical task, but rather easy.

Quote:

Of course I will help for the coding, at least for the common parts.
You shouldn't have said that, see my answer above Smile
Re: TPC MVD and GEM correlators [message #12020 is a reply to message #12013] Thu, 16 June 2011 15:03 Go to previous messageGo to next message
Dima Melnychuk is currently offline  Dima Melnychuk
Messages: 213
Registered: April 2004
Location: National Centre for Nucle...
first-grade participant
From: *fuw.edu.pl
Hi Felix,

turning off GEANE, i.e. commenting the line

tpcSPR->useGeane(); // use RKTrackrep and GeaneTrackrep

I have the same error which Stefano reported:

---------------------------------------------------

*** Number of clusters in track: 10 ***
starting fit
Calling processTrack
starting track8
GFException thrown with excString:
GFRecoHitFactory: no hitProducer for this detID available
in line: 61 in file: /home/dimam/pandaroot/pandaroot/genfit/GFRecoHitFactory.cxx
with fatal flag 0

GFException Info Output
===========================
Numbers Label String:
detID
---------------------------
Numbers:
24.00
===========================
Error: Symbol #include is not defined in current scope run_reco_tpc_evt.C:145:
Error: Symbol exception is not defined in current scope run_reco_tpc_evt.C:145:
Syntax Error: #include <exception> run_reco_tpc_evt.C:145:
Error: Symbol G__exception is not defined in current scope run_reco_tpc_evt.C:145:
Error: type G__exception not defined FILE:/home/dimam/pandaroot/pandaroot/macro/run/tdrct/eta_c/./run_reco_tp c_evt.C LINE:145
*** Interpreter error recovered ***

---------------------------------------------------

Dima
Re: TPC MVD and GEM correlators [message #12021 is a reply to message #12020] Thu, 16 June 2011 15:08 Go to previous messageGo to next message
Felix Boehmer is currently offline  Felix Boehmer
Messages: 149
Registered: May 2007
Location: Munich
first-grade participant

From: *gsi.de
Hi Dima & Stefano,

can you please go to the GenfitTools/trackrep folder and type

svn propget svn:externals

What do you see ?
Is there still a fixed revision for the RKTrackRep?

If so, please remove it by doing

svn propget svn:externals > tempfile
editing tempFile, e.g. removing the version statement in the RKTrackRep line
svn propset svn:externals -F tempfile .
and then doing another svn up there?

If this is the problem then we will have to update the externals definitions... Sorry for the inconvience.


Cheers

Felix

[Updated on: Thu, 16 June 2011 15:09]

Report message to a moderator

Re: TPC MVD and GEM correlators [message #12022 is a reply to message #12013] Thu, 16 June 2011 15:25 Go to previous messageGo to next message
Dima Melnychuk is currently offline  Dima Melnychuk
Messages: 213
Registered: April 2004
Location: National Centre for Nucle...
first-grade participant
From: *fuw.edu.pl
Hi Felix,

svn propget svn:externals
gives for me

LSLtrackRep -r216 https://genfit.svn.sourceforge.net/svnroot/genfit/LSLtrackRep
GeaneTrackRep2 -r216 https://genfit.svn.sourceforge.net/svnroot/genfit/GeaneTrackRep2
RKTrackRep -r313 https://genfit.svn.sourceforge.net/svnroot/genfit/RKTrackRep

I changed as you said version statement in the RKTrackRep line.

After svn update I have the following problem with compilation

-----------------------------------------
Scanning dependencies of target trackrep
[ 79%] Building CXX object GenfitTools/trackrep/CMakeFiles/trackrep.dir/RKTrackRep/RKTrackRep.cxx.o
/home/dimam/pandaroot/pandaroot/GenfitTools/trackrep/RKTrackRep/RKTrackRep.cxx:38:30: error: GFMaterialEffects.h: No such file or directory
/home/dimam/pandaroot/pandaroot/GenfitTools/trackrep/RKTrackRep/RKTrackRep.cxx: In member function ‘bool RKTrackRep::RKutta(const GFDetPlane&, double*, double&, std::vector<TVector3, std::allocator<TVector3> >&, std::vector<double, std::allocator<double> >&, const double&, bool) const’:
/home/dimam/pandaroot/pandaroot/GenfitTools/trackrep/RKTrackRep/RKTrackRep.cxx:697: error: ‘GFMaterialEffects’ has not been declared
/home/dimam/pandaroot/pandaroot/GenfitTools/trackrep/RKTrackRep/RKTrackRep.cxx: In member function ‘double RKTrackRep::Extrap(const GFDetPlane&, TMatrixT<double>*, TMatrixT<double>*) const’:
/home/dimam/pandaroot/pandaroot/GenfitTools/trackrep/RKTrackRep/RKTrackRep.cxx:1059: error: ‘GFMaterialEffects’ has not been declared
make[2]: *** [GenfitTools/trackrep/CMakeFiles/trackrep.dir/RKTrackRep/RKTrackRep.cxx.o] Error 1
make[1]: *** [GenfitTools/trackrep/CMakeFiles/trackrep.dir/all] Error 2
make: *** [all] Error 2


I suspect that the version for genfit itself should also be changed from
genfit -r 313 https://genfit.svn.sourceforge.net/svnroot/genfit/core

And just for completeness, should the version number for GeaneTrackRep2 stay fixed or should it be removed also?

Dima
Re: TPC MVD and GEM correlators [message #12023 is a reply to message #12022] Thu, 16 June 2011 15:34 Go to previous messageGo to next message
Felix Boehmer is currently offline  Felix Boehmer
Messages: 149
Registered: May 2007
Location: Munich
first-grade participant

From: *gsi.de
Hi Dima,

yes, please try to go to the head revision of the genfit core.
We need to solve this urgently.

Keep me updated please


Felix
Re: TPC MVD and GEM correlators [message #12024 is a reply to message #12013] Thu, 16 June 2011 15:47 Go to previous messageGo to next message
Dima Melnychuk is currently offline  Dima Melnychuk
Messages: 213
Registered: April 2004
Location: National Centre for Nucle...
first-grade participant
From: *fuw.edu.pl
Hi Felix,

after updating to the head revision of the genfit core I finally managed to run tpc reconstruction macro for 10 events.

But I suppose that genfit version, including RKTrackRep should be updated centrally in svn repository.

Dima

Re: TPC MVD and GEM correlators [message #12025 is a reply to message #12024] Thu, 16 June 2011 15:51 Go to previous messageGo to next message
Felix Boehmer is currently offline  Felix Boehmer
Messages: 149
Registered: May 2007
Location: Munich
first-grade participant

From: *gsi.de
Yes,

I will communicate this to the genfit developers. We have to find some solution together with Stefano & Co.
Please keep me up to date concerning the results


Cheers

Felix
Re: TPC MVD and GEM correlators [message #12026 is a reply to message #12019] Thu, 16 June 2011 15:56 Go to previous messageGo to next message
StefanoSpataro is currently offline  StefanoSpataro
Messages: 2736
Registered: June 2005
Location: Torino
first-grade participant

From: *to.infn.it
Hi,

Felix Boehmer wrote on Thu, 16 June 2011 14:52

Hi Stefano,

do you have the latest version of the KalmanTask? It looks like you don't and there is one of the RecoHitProducers not properly defined.



It is the 12357, but I have seen you have done a modification at 14:30 which I had not. I will run again.

Quote:


To your questions:

Quote:


Ca we move the tpc clusterization to the digi macro, or remove it in the digi? At present we are running the same code, even if with different parameters, twice

I removed the clustering from the reco macro.



This means that the cluster code in the run_digi_tpc_*.C is fine, isn't it? I have seen it was a bit different from the one in the reco macro.

In the digi:
 PndTpcClusterFinderTask* tpcCF = new PndTpcClusterFinderTask();
  tpcCF->SetDigiPersistence(); // keep Digis refs in clusters
  tpcCF->SetPersistence();     // keep Clusters
  tpcCF->timeslice(10);        //in samples
  tpcCF->SetErrorPars(600,300);
  tpcCF->SetSimpleClustering(); // use PndTpcClusterFinderSimple
  fRun->AddTask(tpcCF);



In the reco:
 PndTpcClusterFinderTask* tpcCF = new PndTpcClusterFinderTask();
  //tpcCF->SetDigiPersistence(); // keep reference to digis in clusters
  tpcCF->SetPersistence(); // keep Clusters
  tpcCF->timeslice(4); //in samples
  tpcCF->SetThreshold(1);
  tpcCF->SetSingleDigiClusterAmpCut(0.);
  tpcCF->SetClusterAmpCut(0.); // cut on mean digi amplitude
  tpcCF->SetErrorPars(600.,400.);
  tpcCF->SetSimpleClustering(); // use PndTpcClusterFinderSimple
  fRun->AddTask(tpcCF);


Which of them?


Quote:


What you describe was my first approach. However, using the MVD hits after TPC+MVD correlation in a fit gives better results for the (possibly very long) extrapolation into the GEMs. I would keep it that way. I agree that it is slow, but it is the best I have right now. The crashes are completely isoloated to GEANE extrapolations into the GEMs as far as I can tell right now... I am working on it, as I said.



So maybe we can take out the first kalman. I am not scared by code crashes or geane crashed, these we can fix, it is matter of track cleaning, taking out tracks which could give errors in arithmetical calculations. I am more scared by crashes connected to memory usage, geane seems to eat a bit of memory and running it three times in the same macro... let's cross the fingers!

Quote:


Quote:

Which particle hypothesis are you using for the kalman?
Is there a way to reduce all those messages? They make the log output file large

The particle hypothesis is obtained from MC information isndie the PndTpcRiemannTrackingTask. I can build in a setter if you want to have manual control during the reco.



Just to know, in stt case we are using the fixed particle hypothesis (muon as default). Probably the mc method should be also implemented in the RecoKalmanTask version.
But a flag, also for the verbose of the kalman, would be great (I suppose with lower priority).


Quote:


I can take a look at this after I have fixed all the other, more urgent problem. I would be very grateful if you could have a lokk at this. Probably the exchange would be a very technical task, but rather easy.



Ok, I have also some objections about the enum fDetectorId, because ti breaks a bit also the pid and analysis part, but first let's see what is happening with the "normal" version.


Re: TPC MVD and GEM correlators [message #12027 is a reply to message #12025] Thu, 16 June 2011 16:02 Go to previous messageGo to next message
Anonymous Poster From: *adsl.alicedsl.de
Hi there,

nothing speaks against using the newest revision of core and RKTrackRep (330). I was surprised to read that 313 wont do it. I dont know exactly what fix is doing the job, but if 330 works that is great.

Cheers, Christian
Re: TPC MVD and GEM correlators [message #12028 is a reply to message #12027] Thu, 16 June 2011 16:06 Go to previous messageGo to next message
Felix Boehmer is currently offline  Felix Boehmer
Messages: 149
Registered: May 2007
Location: Munich
first-grade participant

From: *gsi.de
Hi Christian,

nice that you participate.
What would be the latest genfit core revision we could switch to?


Cheers

Felix
Re: TPC MVD and GEM correlators [message #12029 is a reply to message #12027] Thu, 16 June 2011 16:09 Go to previous messageGo to next message
Johannes Rauch is currently offline  Johannes Rauch
Messages: 41
Registered: September 2010
Location: TUM
continuous participant
From: 140.181.9*
Hi,

I simplified and rearranged the material interface, and that change is in version 316.
So using a post 316 RKTrackRep with a pre 316 core will not work.

We are still investigating in floating point exceptions in the GeaneTrackRep, so for the time being it might be the best to use the head revisions of RK and Geane Trackrep.

The latest revision of the core is 316, since then, the core has not changed.

cheers, Johannes
Re: TPC MVD and GEM correlators [message #12033 is a reply to message #12029] Thu, 16 June 2011 16:56 Go to previous messageGo to next message
StefanoSpataro is currently offline  StefanoSpataro
Messages: 2736
Registered: June 2005
Location: Torino
first-grade participant

From: *to.infn.it
Hi,
I have run 50 events doing an svn update, and now I have no crashes - standard geanetrackrep (ok, I have to test more events).
Still I have not understood which is the "final" object storing the track parameters after tpc+mvd+gem. I can see a TrackPostFitComplete, but if I have understood well that is only a PndTrackCand. Where are momentum and track parameters stored?
Re: TPC MVD and GEM correlators [message #12034 is a reply to message #12033] Thu, 16 June 2011 17:16 Go to previous messageGo to next message
Felix Boehmer is currently offline  Felix Boehmer
Messages: 149
Registered: May 2007
Location: Munich
first-grade participant

From: *gsi.de
Hi Stefano,

TrackPostFitComplete is in fact a GFTrack. You can get all the information out of this object (e.g. the trackrep inside), for example by calling getMom().


Regards

Felix
Re: TPC MVD and GEM correlators [message #12035 is a reply to message #12018] Thu, 16 June 2011 18:04 Go to previous messageGo to next message
Lia Lavezzi
Messages: 291
Registered: May 2007
Location: Torino
first-grade participant

From: *pv.infn.it
Hi all,
in the stacktrace the line 224 of FairGeanePro.cxx is the origin of the crash... in that line I see (I have the latest revision of trunk updated):

ein[i]=fCov[i];

where ein is the vector of the covariance matrix which will be used in GEANE and fCov[i] is the covariance matrix of the track param given in input.

Are all the elements of the covariance matrix filled and with reasonable values (I mean, no 1e-234 or something like this)...

Cheers,
Lia.
Re: TPC MVD and GEM correlators [message #12036 is a reply to message #12035] Thu, 16 June 2011 18:29 Go to previous messageGo to next message
Felix Boehmer is currently offline  Felix Boehmer
Messages: 149
Registered: May 2007
Location: Munich
first-grade participant

From: *gsi.de
Hi Lia,

thank you for helping. Any idea what might be the reason? We're looking into it.


Bye

Felix
Re: TPC MVD and GEM correlators [message #12037 is a reply to message #12013] Thu, 16 June 2011 19:17 Go to previous messageGo to next message
Johannes Rauch is currently offline  Johannes Rauch
Messages: 41
Registered: September 2010
Location: TUM
continuous participant
From: 140.181.9*
Dear Lia,

I just checked in an new version of GeaneTrackRep.
There were some lines in the code where x and y could both become very small.
Could you please check if it solves the problem?

cheers,

Johannes
Re: TPC MVD and GEM correlators [message #12038 is a reply to message #12037] Thu, 16 June 2011 19:29 Go to previous messageGo to next message
Lia Lavezzi
Messages: 291
Registered: May 2007
Location: Torino
first-grade participant

From: *pv.infn.it
Hi Johannes,
from my side it was just an hypothesis, I didn' t run the code I just read the backtrace Dima posted and looked in the geane interface, so maybe he can tell you if the crash disappeares with your last changes...

Cheers,
Lia.
Re: TPC MVD and GEM correlators [message #12040 is a reply to message #12029] Thu, 16 June 2011 23:21 Go to previous messageGo to next message
Johan Messchendorp is currently offline  Johan Messchendorp
Messages: 693
Registered: April 2007
Location: University of Groningen
first-grade participant

From: *xs4all.nl
Hi,

Concerning the revisions of GenfitTools/trackrep .... what is the punchline now?
Shall I change the revision in trunk so that all the users can enjoy that?
If so, which revision numbers to use for the various folders?

Greets,

Johan.
Re: TPC MVD and GEM correlators [message #12041 is a reply to message #12013] Fri, 17 June 2011 00:56 Go to previous messageGo to next message
Dima Melnychuk is currently offline  Dima Melnychuk
Messages: 213
Registered: April 2004
Location: National Centre for Nucle...
first-grade participant
From: *play-internet.pl
Hi all,

first comment is to Felix.
And it is related to removing PndTpcClusterFinderTask from reco macro.
Actually after this task is removed for me tpc reco macro crashes with

Toggle Spoiler


So the problem is that in PndTpcRiemannTrackingTask instance of PndTpcDigiMapper
is called but it is initialised in PndTpcClusterFinderTask. So PndTpcClusterFinderTask should be left in tpc reconstruction macro or PndTpcDigiMapper in
PndTpcRiemannTrackingTask should be properly initialised.

But besides this after updating to the latest GeaneTrackRep I run tpc reconstruction with GeaneTrackRep without crashes.
However I still run the check with higher number of events.

Dima
Re: TPC MVD and GEM correlators [message #12043 is a reply to message #12013] Fri, 17 June 2011 11:24 Go to previous messageGo to next message
Dima Melnychuk is currently offline  Dima Melnychuk
Messages: 213
Registered: April 2004
Location: National Centre for Nucle...
first-grade participant
From: *fuw.edu.pl
Hi all,

I run tpc reco with higher number of events, i.e. 2000 and unfortunately everything stops with an error, however from the log it's difficult to say after which event, but after 9 hours of calculations:

 ... processing TPC track no. 102
======= TempCand from found GEM  hits has size 0 =======

  ... processing TPC track no. 103
======= TempCand from found GEM  hits has size 0 =======

  ... processing TPC track no. 104
======= TempCand from found GEM  hits has size 0 =======

Error: Symbol #include is not defined in current scope  run_reco_tpc_evt.C:145:
Error: Symbol exception is not defined in current scope  run_reco_tpc_evt.C:145:
Syntax Error: #include <exception> run_reco_tpc_evt.C:145:                      
Error: Symbol G__exception is not defined in current scope  run_reco_tpc_evt.C:145:
Error: type G__exception not defined FILE:/d/panda02/dmelnych/pandaroot/pandaroot/macro/run/tdrct/eta_c/lenny64/101/./run_reco_tpc_evt.C LINE:145                                                                                                         
*** Interpreter error recovered ***                                                                                          
Error in ERTRAK : No prediction. Tracking stops now                                                                          

    Error in ERTRAK : No prediction. Tracking stops now

    Error in ERTRAK : No prediction. Tracking stops now

    Error in ERTRAK : No prediction. Tracking stops now

    Error in ERTRAK : No prediction. Tracking stops now



But in addition running on different computer my previous error still persists, i.e.
===========================================================
#10 0x0392f78d in FairGeanePro::Propagate (this=0xeba1948, TStart=0xbfdf3548,
    TEnd=0xbfdf3120, PDG=321)
    at /home/dimam/pandaroot/pandaroot/geane/FairGeanePro.cxx:224
#11 0x03b645fb in GeaneTrackRep::extrapolateToPoint (this=0xf639c78, pos=...,
    poca=..., dirInPoca=...)
    at /home/dimam/pandaroot/pandaroot/GenfitTools/trackrep/GeaneTrackRep/GeaneTrackRep.cxx:305
#12 0x03ac25f9 in GFSpacepointHitPolicy::detPlane (this=0xf6391e8, hit=
    0xf638fe0, rep=0xf639c78)
    at /home/dimam/pandaroot/pandaroot/genfit/GFSpacepointHitPolicy.cxx:95
#13 0x05b6b31d in GFRecoHitIfc<GFSpacepointHitPolicy>::getDetPlane (
    this=0xf638fe0, rep=0xf639c78)
    at /home/dimam/pandaroot/pandaroot/genfit/GFRecoHitIfc.h:80
#14 0x03abc68d in GFKalman::processHit (this=0xbfdf5420, tr=0xf6373b0,
    ihit=10, irep=1, direction=-1)
    at /home/dimam/pandaroot/pandaroot/genfit/GFKalman.cxx:267
#15 0x03abbbbc in GFKalman::fittingPass (this=0xbfdf5420, trk=0xf6373b0,
    direction=-1) at /home/dimam/pandaroot/pandaroot/genfit/GFKalman.cxx:169
#16 0x03abb53e in GFKalman::processTrack (this=0xbfdf5420, trk=0xf6373b0)
    at /home/dimam/pandaroot/pandaroot/genfit/GFKalman.cxx:77
#17 0x078fb83d in KalmanTask::Exec (this=0x9552558, opt=0x323a908 "")
    at /home/dimam/pandaroot/pandaroot/recotasks/KalmanTask.cxx:264
#18 0x00833f31 in TTask::ExecuteTasks (this=0x8a72658, option=0x323a908 "")
    at /home/dimam/pandaroot/fairsoft/tools/root/core/base/src/TTask.cxx:312
#19 0x00833d47 in TTask::ExecuteTask (this=0x8a72658, option=0x323a908 "")
    at /home/dimam/pandaroot/fairsoft/tools/root/core/base/src/TTask.cxx:275
#20 0x0318f557 in FairRunAna::Run (this=0x8a725e0, Ev_start=0, Ev_end=10)
    at /home/dimam/pandaroot/pandaroot/base/FairRunAna.cxx:272
===========================================================



Dima
Re: TPC MVD and GEM correlators [message #12044 is a reply to message #12043] Fri, 17 June 2011 12:33 Go to previous messageGo to next message
Felix Boehmer is currently offline  Felix Boehmer
Messages: 149
Registered: May 2007
Location: Munich
first-grade participant

From: 140.181.9*
Hi Dima,

it's an exception inside the GEANE's extrapolation.

I'm trying to fix it. Keep on testing, please. Have you used RK also for some tests?


Cheers

Felix
Re: TPC MVD and GEM correlators [message #12045 is a reply to message #12013] Fri, 17 June 2011 12:47 Go to previous messageGo to next message
Dima Melnychuk is currently offline  Dima Melnychuk
Messages: 213
Registered: April 2004
Location: National Centre for Nucle...
first-grade participant
From: *fuw.edu.pl
Hi Felix,

I managed to generate a number of events in RKTrackRep and the actual test would be to generate invariant mass plots. But to do it in standard way using rho package TCandidates are needed, which are generated by PndPidCorrelator from PndTrack. And as Stefano has written to have PndTrack there two options: to use PndRecoKalmanTask instead of KalmanTask or to create separate task to convert TClonesArray of GFTrack to TClonesArray of PndTrack.
Second option is rather easy using using PndGenfitAdapters.cxx but I understood that Stefano was in favour of first option.

And here I want to ask Stefano for comment if he tried to do something in this direction already. And if he does not foresee to have something ready today I consider to write by myself a Task for GFTrack->PndTrack conversion.

Dima
Re: TPC MVD and GEM correlators [message #12046 is a reply to message #12045] Fri, 17 June 2011 13:10 Go to previous messageGo to next message
StefanoSpataro is currently offline  StefanoSpataro
Messages: 2736
Registered: June 2005
Location: Torino
first-grade participant

From: *to.infn.it
Hi,
there are mainly two problems:
a) the code is using the obsolete fDetectorId style, which is not compatible with the PndRecokalmanTask and neither with PndPidCorrelator
b) the code is producing gftracks and not pndtrack

For a) I can try to fix it writing a PndDetectorListFake, where the enum becomes a series of constants, i.e.:
const Int_t kTpcCluster = FairRootManager::Instance()->GetBranchId("PndTpcCluster")

In this way, all the tpc class headers should use PndDetectorListFake instead of PndDetectorList. Of course this is only a momentary solution and after the TDR activities it should be fixed in the tracking code itself.

For b) a task as adapter would be great. I cannot do it because I have to fix many other things on the grid side, but if you want to spend some time... it could be placed in GenfitTools/recotasks. The scheme should be already present in PndRecoKalmanTask/Fit and it is just a matter of copy and paste (hopefully). But after you will have the problem with the mvd part of the PndPidCorrelator. To avoid it, you should switch off mvd pid: corr->SetMvdMode(0) using the last version of the PndPidCorrelator.
Re: TPC MVD and GEM correlators [message #12051 is a reply to message #12046] Fri, 17 June 2011 14:29 Go to previous messageGo to next message
Felix Boehmer is currently offline  Felix Boehmer
Messages: 149
Registered: May 2007
Location: Munich
first-grade participant

From: *gsi.de
Hi Stefano,

I had originally already implemented the PndTracks and PndTrackCands in the ideal TPC PR about a year ago.

We didn't include it in the RiemannPR because we keep having problems with the FairLinks when creating these objects. As you know, we can't use them for the TPC code because of memory issues.

If you can fiddle together an adapter I would be most grateful, but right now our focus is on finding out what goes wrong with GEANE.


Cheers

Felix
Re: TPC MVD and GEM correlators [message #12056 is a reply to message #12013] Fri, 17 June 2011 16:53 Go to previous messageGo to next message
Dima Melnychuk is currently offline  Dima Melnychuk
Messages: 213
Registered: April 2004
Location: National Centre for Nucle...
first-grade participant
From: *fuw.edu.pl
Hi all,

I tried to implement task for GFTrack to PndTrack conversion using adapters from GenfitTools/adapters/PndGenfitAdapters.cxx and trying to run it in tpc reco task I observed that GenfitTrack2PndTrack adapter support only GeaneTrackRep.
So as a next step I tried to edit PndGenfitAdapters.cxx to support also RKTrackRep.

So from the compilation and run-time point of view everything work. I.e. I have a TClonesArray of PndTrack.

The class is called PndGFTrackToPndTrackConvertorTask
and I assume that it should be called in tpc reconstruction macro after last KalmanTask.

  PndGFTrackToPndTrackConvertorTask* converter =new PndGFTrackToPndTrackConvertorTask();
  converter->SetTrackInBranchName("TrackPostFitComplete");
  converter->SetTrackOutBranchName("PndTrackPostFitComplete");
  fRun->AddTask(converter);


I tried to check in the code but I do not have write access to GenfitTools directory.

I attached the files (PndGFTrackToPndTrackConvertorTask.cxx, PndGFTrackToPndTrackConvertorTask.h) to be placed /GenfitTools/recotasks/ with corrected CMakeList.txt and RecoTasksLinkDef.h and corrected adapter PndGenfitAdapters.cxx to be placed to /GenfitTools/adapters/.

In addition in /GenfitTools/adapters/CMakeList.txt there is an error
It should be instead of

${CMAKE_SOURCE_DIR}/GenfitTools/trackrep/RKtrackRep

the following

${CMAKE_SOURCE_DIR}/GenfitTools/trackrep/RKTrackRep

i.e. capital "T" instead of small one.

So could some body check it in, Stefano or Felix?

Now I will try to run higher statistics to see if the results are reasonable, but it will take some time.

Dima
Re: TPC MVD and GEM correlators [message #12057 is a reply to message #12056] Fri, 17 June 2011 17:58 Go to previous messageGo to next message
StefanoSpataro is currently offline  StefanoSpataro
Messages: 2736
Registered: June 2005
Location: Torino
first-grade participant

From: *to.infn.it
Done,
it compiles, I don't know if it works also Smile
Test and modifications to macros are welcome, I had no time to try.

[Updated on: Fri, 17 June 2011 18:04]

Report message to a moderator

Re: TPC MVD and GEM correlators [message #12058 is a reply to message #12013] Fri, 17 June 2011 18:17 Go to previous messageGo to next message
Dima Melnychuk is currently offline  Dima Melnychuk
Messages: 213
Registered: April 2004
Location: National Centre for Nucle...
first-grade participant
From: *fuw.edu.pl
Hi Stefano,

Could you may be also update revision of genfit and RKTrackRep to 330 if you have write access to have this point also settled.
I just updated from the trunk and had to return it by hand from 313 to 330 again in my local installation to resolve the conflict.

Dima
Re: TPC MVD and GEM correlators [message #12059 is a reply to message #12058] Fri, 17 June 2011 18:31 Go to previous messageGo to next message
StefanoSpataro is currently offline  StefanoSpataro
Messages: 2736
Registered: June 2005
Location: Torino
first-grade participant

From: *to.infn.it
No, this I cannot do it.
Only Mohammad and Florian, I suppose.
Re: TPC MVD and GEM correlators [message #12060 is a reply to message #12059] Fri, 17 June 2011 18:56 Go to previous messageGo to next message
Mohammad Al-Turany is currently offline  Mohammad Al-Turany
Messages: 518
Registered: April 2004
Location: GSI, Germany
first-grade participant
From: *dip.t-dialin.net
Hi,

Stefano and Johan could also do it! any way I set it to 330.

regards,

Mohammad
Re: TPC MVD and GEM correlators [message #12062 is a reply to message #12060] Fri, 17 June 2011 20:20 Go to previous message
StefanoSpataro is currently offline  StefanoSpataro
Messages: 2736
Registered: June 2005
Location: Torino
first-grade participant

From: *4-87-r.retail.telecomitalia.it
The correct sentence was "I have no idea how to do it":)
Previous Topic: [FIXED] Bug in EvtGenDirect
Next Topic: Bug in parameter handling?
Goto Forum:
  


Current Time: Sat Nov 27 23:49:32 CET 2021

Total time taken to generate the page: 0.02353 seconds