GSI Forum
GSI Helmholtzzentrum für Schwerionenforschung
Home » PANDA » PandaRoot » General » Abandonware
Abandonware [message #4929] Fri, 17 August 2007 12:37 Go to next message
StefanoSpataro is currently offline  StefanoSpataro
Messages: 2736
Registered: June 2005
Location: Torino
first-grade participant
From: *physik.uni-giessen.de
I am wondering if it is the case to remove from the PandaRoot root directory all those packages which are now obsolete.

These are, if I have understood well:

  • bfield (obsolete, now field is the official one)
  • stt1 (obsolete, now stt is the official one)
  • stt2 (obsolete, now stt is the official one)
  • fsc (it is now included inside emc)


I think it is meaningless to continue to download and compile code that we do not use anymore.
Maybe it could be the case to create an "archive" directory that is not downloaded from svn, where we can put all these obsolete packages.

Comments and ideas are welcome

Ste

Report message to a moderator

Re: Abandonware [message #4931 is a reply to message #4929] Fri, 17 August 2007 12:52 Go to previous messageGo to next message
Aleksandra Wronska is currently offline  Aleksandra Wronska
Messages: 38
Registered: May 2006
Location: Cracow
continuous participant
 From: *if.uj.edu.pl
No objections from my side concerning fsc.

ola

Report message to a moderator

Re: Abandonware [message #4950 is a reply to message #4929] Tue, 21 August 2007 12:23 Go to previous messageGo to next message
Pablo Genova is currently offline  Pablo Genova
Messages: 32
Registered: May 2007
continuous participant
 From: *PV.INFN.IT
I perfectly agree with you, Pablo

Report message to a moderator

Re: Abandonware [message #4959 is a reply to message #4929] Wed, 22 August 2007 17:49 Go to previous messageGo to next message
StefanoSpataro is currently offline  StefanoSpataro
Messages: 2736
Registered: June 2005
Location: Torino
first-grade participant
From: *physik.uni-giessen.de
Dear all,
I removed from the main makefile the libraries stt1 stt2 fsc and bfield, and I added stt (that was missing before) and tof.
Even the Dart.sh file should be updated.

I will keep them for another week, then I will delete them.

Stt package was never compiled before under Dashboard, so all the deprecated warings are still there.

There are 19 warnings still existing, could you please remove them? I could do it, if you agree, but there is one warning (the last one) that I could not understand.

Thanks

Report message to a moderator

Re: Abandonware [message #4962 is a reply to message #4959] Thu, 23 August 2007 16:00 Go to previous messageGo to next message
Pablo Genova is currently offline  Pablo Genova
Messages: 32
Registered: May 2007
continuous participant
 From: *PV.INFN.IT
Hi Stefano,

I fixed the trivial warnings due to the deprecated headers and committed to svn. Now you should see only 2 warnings, which I do not know how to fix.

One is
/data10/pablo/tmp/pandaroot/stt/CbmSttTrackFinderIdeal.cxx: In member function
`virtual Int_t CbmSttTrackFinderIdeal::DoFind(TClonesArray*)':
/data10/pablo/tmp/pandaroot/stt/CbmSttTrackFinderIdeal.cxx:202: warning: passing
`Double_t' for argument 1 of `_Tp& std::map<_Key, _Tp, _Compare,
_Alloc>::operator[](const _Key&) [with _Key = Int_t, _Tp = Int_t, _Compare =
std::less<Int_t>, _Alloc = std::allocator<std::pair<const Int_t, Int_t> >]'

and the other is

/data10/pablo/tmp/pandaroot/stt/CbmSttHelixTrackFitter.cxx: In member function
`virtual Int_t CbmSttHelixTrackFitter::DoFit(CbmSttTrack*, int)':
/data10/pablo/tmp/pandaroot/stt/CbmSttHelixTrackFitter.cxx:168: warning: NULL used in arithmetic

due to a control like (function() !=NULL).

I do not know how to fix them, I'm surprised of the latter because it is quite common that one checks if a pointer is not null, so I do not know how to keep the test but eliminate the warning.

ciao, Pablo

Report message to a moderator

Re: Abandonware [message #4963 is a reply to message #4962] Thu, 23 August 2007 16:47 Go to previous messageGo to next message
StefanoSpataro is currently offline  StefanoSpataro
Messages: 2736
Registered: June 2005
Location: Torino
first-grade participant
From: *physik.uni-giessen.de
Hi,
I will check the first one.

For the second one I think the problem is that you are not comparing a pointer, but a number.

Indeed in the expression:

(pTrack->GetParamLast()->GetTx()) != NULL


pTrack is a pointer to a CbmSttTrack,
pTrack->GetParamLast() is a pointer to a CbmTrackParam,
but pTrack->GetParamLast()->GetTx() is a double so a number! Maybe you should remove GetTx or something else, to clean that condition.

P.S. I removed the headers in tof code

Report message to a moderator

Re: Abandonware [message #4964 is a reply to message #4963] Thu, 23 August 2007 17:02 Go to previous messageGo to next message
Pablo Genova is currently offline  Pablo Genova
Messages: 32
Registered: May 2007
continuous participant
 From: *PV.INFN.IT
Stefano,

you are perfectly right! That check was completely meaningless Sad. Now it has been properly modified ((..)>0).

Thank you very much for the remark. Smile


Pablo

Report message to a moderator

Re: Abandonware [message #4965 is a reply to message #4962] Thu, 23 August 2007 17:04 Go to previous messageGo to next message
StefanoSpataro is currently offline  StefanoSpataro
Messages: 2736
Registered: June 2005
Location: Torino
first-grade participant
From: *physik.uni-giessen.de
About the first warning, this is not so clear to me.

You define hitMap as:

map<Int_t, map<Int_t, Int_t> > hitMap;

Then:

Double_t wireX = pMhit->GetX(), wireY = pMhit->GetY();
(hitMap[mcTrackIndex])[wireX * wireX + wireY * wireY]++;

The map is <Int_t, Int_t> but then you give one index as [double].
I think you can (one of the two)
a) correct the map putting one double inside (map<Int_t, Double_t>)
b) overcast the wire id (Int_t)(wireX * wireX + wireY * wireY)

Just at a first sight the first should be the correct one, in each case I am wondering how does it work with this int/double ambiguity...

Report message to a moderator

Re: Abandonware [message #4978 is a reply to message #4965] Mon, 27 August 2007 13:07 Go to previous messageGo to next message
Pablo Genova is currently offline  Pablo Genova
Messages: 32
Registered: May 2007
continuous participant
 From: *PV.INFN.IT
the map has been corrected according to method a),
the plots of the standard reconstruction macros are OK.

ciao, Pablo

Report message to a moderator

Re: Abandonware [message #4980 is a reply to message #4978] Mon, 27 August 2007 13:40 Go to previous messageGo to next message
StefanoSpataro is currently offline  StefanoSpataro
Messages: 2736
Registered: June 2005
Location: Torino
first-grade participant
From: *physik.uni-giessen.de
Ladies and Gentlemen,
I am proud to announce that for the first time in the PandaRoot life we have absolutely NO WARNING at all!! Smile

Let's hope to keep this profile as long as possible ...

Bye

Report message to a moderator

Removed obsolete packages [message #5041 is a reply to message #4929] Thu, 13 September 2007 14:24 Go to previous message
StefanoSpataro is currently offline  StefanoSpataro
Messages: 2736
Registered: June 2005
Location: Torino
first-grade participant
From: *physik.uni-giessen.de
Hello,

the obsolete packages since revision 1496 are removed from the repository.

If somebody wants to retrieve the old code, he should call the revision 1495 (or below).

Regards

Report message to a moderator

Previous Topic: just for fun...
Next Topic: Separation of elastic and inelastic scatterings
Goto Forum:
  

[ Syndicate this forum (XML) ] [ RSS ] [ PDF ]

Current Time: Sat Apr 27 16:32:52 CEST 2024

Total time taken to generate the page: 0.00800 seconds
.:: Contact :: Home :: Legal Notice :: Data Protection Policy ::.

Powered by: FUDforum 3.1.2.
Copyright ©2001-2022 FUDforum Bulletin Board Software