GSI Forum
GSI Helmholtzzentrum für Schwerionenforschung

Home » PANDA » PandaRoot » Bugs, Fixes, Releases » genfit: TrackCand available
genfit: TrackCand available [message #4236] Tue, 15 May 2007 14:07 Go to next message
Sebastian Neubert is currently offline  Sebastian Neubert
Messages: 282
Registered: March 2006
Location: Munich
first-grade participant

From: *e18.physik.tu-muenchen.de
Hi!

genfit now provides a class called TrackCand which just manages a list of hit ids. This is the basic class for pattern recognition.

In the near future this class will get the functionality to be merged with other candidates.

To use this update genfit and recotasks. In the demo the TrackCand idates are already used.

There is still one issue which we have to think about:
at the moment as soon as you put the TrackCand into a Track object the candidate is copied. So data is in principle duplicated which is not nice.

However if we would pass a pointer onto the candidate to the track, we would have to make sure, that the track is notified when somebody changes something in the candidate, since in that case the fits are not valid anymore.

We are thinking about a system that tracks changes to the reco objects and ensures a constistent state at all time.

Cheers! Sebastian.


Sebastian Neubert
Technische Universität München
Department Physik E18
sneubert@e18.physik.tu-muenchen.de
tel: +49-8928912592
Re: genfit: TrackCand available [message #4240 is a reply to message #4236] Tue, 15 May 2007 15:26 Go to previous messageGo to next message
StefanoSpataro is currently offline  StefanoSpataro
Messages: 2736
Registered: June 2005
Location: Torino
first-grade participant

From: *physik.uni-giessen.de
I tried to download the last svn version (741) but I could not compile it, for an error on the Tpc code.

First there are strange warnigs (apart several about the comparisons between signed and unsigned integer expressions...):

../../pandaroot/tpc/TpcPadPlane.h: In constructor `
TpcPadPlane::TpcPadPlane(int, int, double, double, double, double)':
../../pandaroot/tpc/TpcPadPlane.h:145: warning: `TpcPadPlane::_nSectors' will
be initialized after
../../pandaroot/tpc/TpcPadPlane.h:135: warning: `TpcPadPlane::PadIndexer
TpcPadPlane::Indexer'
../../pandaroot/tpc/TpcPadPlane.cxx:42: warning: when initialized here

../../pandaroot/tpc/TpcInhFieldDrifter.h: In constructor `
TpcInhFieldDrifter::TpcInhFieldDrifter(std::basic_string<char,
std::char_traits<char>, std::allocator<char> >, std::basic_string<char,
std::char_traits<char>, std::allocator<char> >, int, int)':
../../pandaroot/tpc/TpcInhFieldDrifter.h:51: warning: `
TpcInhFieldDrifter::_outFile' will be initialized after
../../pandaroot/tpc/TpcInhFieldDrifter.h:48: warning: `double
TpcInhFieldDrifter::_sc'
../../pandaroot/tpc/TpcInhFieldDrifter.cxx:44: warning: when initialized here


Then the errors:

../../pandaroot/tpc/TpcXYRecoHit.cxx: In member function `virtual double
TpcXYRecoHit::residualScalar(double, const AbsTrackRep*, const
TMatrixT<double>&)':
../../pandaroot/tpc/TpcXYRecoHit.cxx:117: warning: control reaches end of
non-void function
In file included from ../../pandaroot/tpc/TpcSimplePatternRecoTask.cxx:30:
../../pandaroot/genfit/Track.h: In member function `void
Track::setCardinalRep(unsigned int)':
../../pandaroot/genfit/Track.h:95: warning: comparison between signed and
unsigned integer expressions
../../pandaroot/tpc/TpcSimplePatternRecoTask.cxx: In member function `virtual
void TpcSimplePatternRecoTask::Exec(const Option_t*)':
../../pandaroot/tpc/TpcSimplePatternRecoTask.cxx:113: error: `addHitIndices'
undeclared (first use this function)
../../pandaroot/tpc/TpcSimplePatternRecoTask.cxx:113: error: (Each undeclared
identifier is reported only once for each function it appears in.)
../../pandaroot/tpc/TpcSimplePatternRecoTask.cxx:122: error: `getHitIndices'
undeclared (first use this function)

../../pandaroot/tpc/TpcSimplePatternRecoTask.cxx:157: error: `getDetIDs'
undeclared (first use this function)
../../pandaroot/tpc/TORPadProcessor.h: In constructor `
padprocessor::padprocessor(unsigned int)':
../../pandaroot/tpc/TORPadProcessor.h:84: warning: `padprocessor::_active_state
' will be initialized after
../../pandaroot/tpc/TORPadProcessor.h:81: warning: `int
padprocessor::_dominant_neighb'
../../pandaroot/tpc/TORPadProcessor.cxx:42: warning: when initialized here
../../pandaroot/tpc/TORPadProcessor.h:81: warning: `
padprocessor::_dominant_neighb' will be initialized after
../../pandaroot/tpc/TORPadProcessor.h:76: warning: `unsigned int
padprocessor::_myid'
../../pandaroot/tpc/TORPadProcessor.cxx:42: warning: when initialized here
make[1]: *** [TpcSimplePatternRecoTask.lo] Error 1
make[1]: *** Waiting for unfinished jobs....


I have seen that the genfit/Track.h was changed.
Is it possible to fix the bug?
Thanks.






Re: genfit: TrackCand available [message #4241 is a reply to message #4240] Tue, 15 May 2007 15:55 Go to previous message
Sebastian Neubert is currently offline  Sebastian Neubert
Messages: 282
Registered: March 2006
Location: Munich
first-grade participant

From: *e18.physik.tu-muenchen.de
Hi!

Don't care about the warnings at the moment, they are low priority.

The error is bad. I recommend not to update tpc until there is a new announced revision. I will work on that, but it will take some time.

Sebastian.


Sebastian Neubert
Technische Universität München
Department Physik E18
sneubert@e18.physik.tu-muenchen.de
tel: +49-8928912592
Next Topic: New pipe geometry (correction)
Goto Forum:
  


Current Time: Tue Apr 30 22:00:47 CEST 2024

Total time taken to generate the page: 0.00798 seconds