[SOLVED] Event filter after simulation phase [message #24814] |
Thu, 23 April 2020 14:57 |
MG
Messages: 5 Registered: April 2020
|
occasional visitor |
From: *telnet.krakow.pl
|
|
Hello!
I'm trying to implement a filter, that would run after the geant simulation and decide whether to store an event or not.
I've written a simple FairTask, which loads the branches I'm interested in and registers them for output. The exec method is just:
std::cout << "test1" << std::endl;
if(rand() % 2)
FairRunSim::Instance()->MarkFill(false);
else
FairRunSim::Instance()->MarkFill(true);
Now, if I use FairRunAna and run this as a task on already generated ntuple, it works flawlessly, saving about half of the events to the new ntuple.
However, if I use FairRunSim as above and add the task in my generation script, I can see that it runs after each event ("test1" is printed for each of the events), but all of the output is saved anyway. I've tried setting the storage of branches I register in the detector code to false, but it doesn't change anything. I've also tried changing the name under which I've registered one of the branches in the task (MCTrack -> MCTrack2) and it saved both MCTrack and MCTrack2 with the same number of events.
What am I doing wrong? Is it possible that the GeoTracks or MCTrack, which are also saved, but I can't control them from the detector (I think), force the tree write in between the simulation and my task?
Thank you very much for help!
[Updated on: Mon, 27 April 2020 14:40] Report message to a moderator
|
|
|
|
|
|
Re: Event filter after simulation phase [message #24830 is a reply to message #24814] |
Fri, 24 April 2020 23:05 |
MG
Messages: 5 Registered: April 2020
|
occasional visitor |
From: *telnet.krakow.pl
|
|
I got a bit stuck again. I've implemented custom Stack based on the example, along with a simple filter on track momentum. What I've found is that the tracks are indeed removed, but hits from these tracks registered in detector are not, they just have their trackID set to -2. I would like to remove these hits as well.
I've tried updating the loop in FairStack::UpdateTrackIndex method, adding
if(-2 == point->GetTrackID())
hitArray->RemoveAt(iPoint);
at the end, after the indices are set properly and also modified the loop to go backwards, so I don't break the indexing by removing items:
for (Int_t iPoint = nPoints - 1; iPoint >= 0; --iPoint)
This produces interesting results, which I've found after printing the size of hitArray before and after the call to RemoveAt. Basically, it works correctly up to some point and then stops removing items, even though the index is smaller than the size of the array.
Example:
Quote:
index 13 trackID -2
size before 14
size after 13
index 12 trackID -2
size before 13
size after 12
index 11 trackID -2
size before 12
size after 11
index 10 trackID 7
index 9 trackID -2
size before 11
size after 11
index 8 trackID -2
size before 11
size after 11
This behavior continues through many events and then it crashes with segmentation violation at some point (like 800 events in). It seems to always appear after the first case of trackID not being -2, as if only removing items from the end of CloneArray worked. My guess is that I'm breaking something with memory, because the branch is already registered and filled.
Is there a better way to do this?
Thanks!
|
|
|
|
|
|