GSI Forum
GSI Helmholtzzentrum für Schwerionenforschung

Home » PANDA » PandaRoot » Bugs, Fixes, Releases » Compilation errors in trunk release 28886
icon4.gif  Compilation errors in trunk release 28886 [message #19001] Tue, 09 February 2016 15:43 Go to next message
Marcel Tiemens is currently offline  Marcel Tiemens
Messages: 47
Registered: January 2014
continuous participant
From: *kvi-cart.rug.nl
Hi all,

I just reinstalled FairRoot and PandaRoot, and during the compilation of PandaRoot, I encountered some failures that needed fixing before I could compile. Some of the things are really strange, and I would think that they would show up when whoever wrote the code tries to compile it him/herself. Here's the list:

PndMdtPointsToWaveform.h: Remove "#pragma once"
PndMdtWaveform.h: Remove "#pragma once"
PndMdtIGeometry.cxx: ofstream -> std::ofstream
PndMdtIGeometry.h: Make a lot of stuff (at least the structs) not private
PndMdtParamDigi.h: Make a lot of stuff (at least the structs) not private
PndEmcBump.h: Remove "#pragma once"
PndEmcRecoPar.h: Remove "#pragma once"
PndRichRecoTask.cxx: #include <db_cxx.h> not necessary (I didn't have the required library on my system, but it compiled when taking that part out without complaining, so I guess it's not used anywhere)
PndCAGlobalPerformance.cxx: line 148: sort -> std::sort
PndCAPerformance.cxx: ofstream -> std::ofstream, ifstream -> std::ifstream

I guess some compilers might not complain about the 'std' parts. As for the "#pragma once", I am not an expert, but as far as I understand you should not use it in combination with
#ifndef MYFILE_H
#define MYFILE_H
... contents of myfile.h
#endif /* !MYFILE_H */
Re: Compilation errors in trunk release 28886 [message #19002 is a reply to message #19001] Tue, 09 February 2016 15:53 Go to previous messageGo to next message
StefanoSpataro is currently offline  StefanoSpataro
Messages: 2736
Registered: June 2005
Location: Torino
first-grade participant

From: *to.infn.it
Which OS do you have? The code nicely compiles on Ubuntu14.04, Ubuntu 15.10, OS X and also on debian.
Re: Compilation errors in trunk release 28886 [message #19003 is a reply to message #19001] Tue, 09 February 2016 15:57 Go to previous messageGo to next message
Dominik Steinschaden is currently offline  Dominik Steinschaden
Messages: 28
Registered: April 2015
continuous participant
From: *smi.oeaw.ac.at
I was just updating my local trunk Version also and I'm now also not able to compile anymore.

But the only Problem seems to be

rich/PndRichRecoTask.cxx:16:20: fatal error: db_cxx.h: No such file or directory
#include <db_cxx.h>
^
compilation terminated.
make[2]: *** [rich/CMakeFiles/Rich.dir/PndRichRecoTask.cxx.o] Error 1
make[1]: *** [rich/CMakeFiles/Rich.dir/all] Error 2
make: *** [all] Error 2

The other errors are not reproduceable. at least not for me
so the other errors are maybe only occuring when using a specific OS or compiler

regards Dominik

[Updated on: Tue, 09 February 2016 15:59]

Report message to a moderator

Re: Compilation errors in trunk release 28886 [message #19004 is a reply to message #19002] Tue, 09 February 2016 15:58 Go to previous messageGo to next message
Marcel Tiemens is currently offline  Marcel Tiemens
Messages: 47
Registered: January 2014
continuous participant
From: *kvi-cart.rug.nl
Ubuntu 14.04, compiler: GCC 4.8
Re: Compilation errors in trunk release 28886 [message #19005 is a reply to message #19004] Tue, 09 February 2016 16:07 Go to previous messageGo to next message
StefanoSpataro is currently offline  StefanoSpataro
Messages: 2736
Registered: June 2005
Location: Torino
first-grade participant

From: *to.infn.it
Just to be sure: mar15 and v15.11?
Can you please send the log of the compilation errors?
Re: Compilation errors in trunk release 28886 [message #19006 is a reply to message #19003] Tue, 09 February 2016 16:08 Go to previous messageGo to next message
StefanoSpataro is currently offline  StefanoSpataro
Messages: 2736
Registered: June 2005
Location: Torino
first-grade participant

From: *to.infn.it
Which OS and compiler?
mar15 and v.1511?
Re: Compilation errors in trunk release 28886 [message #19007 is a reply to message #19001] Tue, 09 February 2016 16:18 Go to previous messageGo to next message
Dominik Steinschaden is currently offline  Dominik Steinschaden
Messages: 28
Registered: April 2015
continuous participant
From: *smi.oeaw.ac.at
I'm using
fairsoft: nov15
fairroot: v15.11 (with slight changes to the FairWriteoutbuffer)

Os: Ubuntu 14.04

How do I check which Compiler is used for the compilation?

at least my gcc/g++ Version is also 4.8.4
Re: Compilation errors in trunk release 28886 [message #19008 is a reply to message #19007] Tue, 09 February 2016 16:48 Go to previous messageGo to next message
Radoslaw Karabowicz is currently offline  Radoslaw Karabowicz
Messages: 108
Registered: June 2004
Location: GSI
continuous participant
From: *dip0.t-ipconnect.de
Which root did you use?
What is the output of root-config --version?
Re: Compilation errors in trunk release 28886 [message #19009 is a reply to message #19008] Tue, 09 February 2016 17:12 Go to previous messageGo to next message
Marcel Tiemens is currently offline  Marcel Tiemens
Messages: 47
Registered: January 2014
continuous participant
From: *kvi-cart.rug.nl
Okay, I attached the log (as far as I could construct it).

I'm using ROOT 6.06/00

And indeed mar15 for the external packages and FairRoot v15-11

[Updated on: Tue, 09 February 2016 17:13]

Report message to a moderator

Re: Compilation errors in trunk release 28886 [message #19010 is a reply to message #19009] Tue, 09 February 2016 17:19 Go to previous messageGo to next message
StefanoSpataro is currently offline  StefanoSpataro
Messages: 2736
Registered: June 2005
Location: Torino
first-grade participant

From: 202.122.36*
Hi Marcel,
I am sorry but the system is not maintained for root6.
The suggested FairRoot version is mar15 where root6 is not yet available, and I do not have a running version of pandaroot with root6. This means, at present, we cannot ask developers to follow root6 directives.

[Updated on: Tue, 09 February 2016 17:38]

Report message to a moderator

Re: Compilation errors in trunk release 28886 [message #19011 is a reply to message #19007] Tue, 09 February 2016 17:23 Go to previous messageGo to next message
StefanoSpataro is currently offline  StefanoSpataro
Messages: 2736
Registered: June 2005
Location: Torino
first-grade participant

From: 202.122.36*
Hi Domink,
I checked the recent log and noticed a file was wrongly committed, PndRichRecotask.cxx. I have reverted the change, please update 28891 and try again.
Re: Compilation errors in trunk release 28886 [message #19012 is a reply to message #19010] Tue, 09 February 2016 17:37 Go to previous messageGo to next message
Marcel Tiemens is currently offline  Marcel Tiemens
Messages: 47
Registered: January 2014
continuous participant
From: *kvi-cart.rug.nl
It's okay - I managed to get it working with the "fixes" I showed. I just thought it would be good to be aware of these errors.
Re: Compilation errors in trunk release 28886 [message #19014 is a reply to message #19001] Tue, 09 February 2016 21:43 Go to previous message
Dmitry Morozov is currently offline  Dmitry Morozov
Messages: 34
Registered: May 2007
Location: Protvino, Russia
continuous participant
From: 185.6.127*
I can confirm the compilation failure for two items:

1) PndMdtIGeometry.h: the structs are private
PndMdtParamDigi.h: the structs are private

Solved by making the structs public

2) PndRichRecoTask.cxx: #include <db_cxx.h> not found
Fixed in rev 28892


System: Fedora 23
Compiler: gcc 5.3.1
FairSoft: nov15
FairRoot: 15.11a
root: 5.34/34

The Log is attached.
  • Attachment: error.log
    (Size: 34.18KB, Downloaded 232 times)
Previous Topic: [FIXED] Bug in Rho with "static"
Next Topic: [FIXED] MC matching
Goto Forum:
  


Current Time: Sun Nov 24 06:27:26 CET 2024

Total time taken to generate the page: 0.00478 seconds