GSI Forum: Bugs, Fixes, Releases » [FIXED] Possible bug in PndEmcClusterMoments.cxx

Home » PANDA » PandaRoot » Bugs, Fixes, Releases » [FIXED] Possible bug in PndEmcClusterMoments.cxx

Show: Today's Messages :: Polls :: Message Navigator

[FIXED] Possible bug in PndEmcClusterMoments.cxx [message #17131]

Tue, 05 August 2014 10:59

Dariusch Deermann
Messages: 2
Registered: August 2014
Location: Germany

occasional visitor

From: *ext.kfa-juelich.de

I tried installing Pandaroot with the newest external packages and received an error in PndEmcClusterMoments.cxx at line 340.
I was told to use the external packages from apr13 and now its compiling without any error or warning regarding this line, but when looking into it it really seems not correct:

aVector += displacement * displacement * digi->GetEnergy();

Here we have a TVector3 += TVector3^2 (=scalar) * scalar. So basically TVector3 += scalar, which doesn't make sense to me.
Since Pandaroot is now compiling without an error or warning for this, i'm not sure whether this is relevant, but it looks strange to me.

[Updated on: Wed, 10 September 2014 12:00] by Moderator

Report message to a moderator

Re: Possible bug in PndEmcClusterMoments.cxx [message #17132 is a reply to message #17131]

Tue, 05 August 2014 11:08

Tobias Stockmanns
Messages: 489
Registered: May 2007

first-grade participant

From: *dip0.t-ipconnect.de

Dear Dariusch,

I agree with your comment that this line looks very strange.
In newer Root versions this line of code causes an error because the constructor of TVector3 has changed. In the older versions (of apr13) one could still initialize a TVector3 with just one scalar. In the newer versions this if forbidden and you need three scalars.

Cheers,

Tobias

Report message to a moderator