GSI Forum: Bugs, Fixes, Releases » Results from Rule Checker

Home » PANDA » PandaRoot » Bugs, Fixes, Releases » Results from Rule Checker

Show: Today's Messages :: Polls :: Message Navigator

Results from Rule Checker [message #5437]

Fri, 16 November 2007 18:40

Florian Uhlig
Messages: 424
Registered: May 2007

first-grade participant

From: *gsi.de

Hi

I included the RuleChecker from ITC-IRST in our framework. This
Rulechecker is used by all the big LHC collaborations to check there code against their coding conventions. Since some weks we have the OK to use it too.

As a start i used the rule set from ALICE adapted for Pnd (e.g. Naming convention that classes start with Pnd).

The idea is to run the checks on a nightly basis here at GSI and provide the results on our dashboard webpage. The results for revision 1791 can be found already on the dashboard. Goto

http://lxg1417.gsi.de:8081/PandaRoot/Dashboard/

and click on Rule Checker on top of the page.

This brings you to an table where you see the number of violations for the libraries and several rules. If you click on the numbers you go to the file showing all the violations. I fyou click on the rules you see (guess) the rules.

This should not be the final word about the Rule Checker. This is what we have now. For example all the rules has to be checked and maybe changed or removed, but i think this is a point to start a discussion.

Have a lot of fun with this table. Embarassed

Ciao

Florian

Report message to a moderator

Re: Results from Rule Checker [message #5441 is a reply to message #5437]

Mon, 19 November 2007 17:07

Ralf Kliemt
Messages: 508
Registered: May 2007
Location: GSI, Darmstadt

first-grade participant

From: 141.30.85*

Hi,

I attended some of the coding rule validations in the mvd code. Here are some suggestions:
The rule GC1 should ignore comments in Front of the first preprocessor command.
Is the rule RC10 needed? This means every Task has to come with a copy constructor.
The link to the doxygen documentation points to an very old (1.0?) version of pandaroot. I'd like to have a link to the current one there, too.

Kind regards, Ralf.

Report message to a moderator

Previous Topic:	Symbol TG4PhysicsListOptionsoptions is not defined in current scope
Next Topic:	pandaroot not compiling at gsi

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Sat Dec 13 22:01:11 CET 2025

Total time taken to generate the page: 0.00716 seconds