GSI Forum: Bugs, Fixes, Releases

Home » PANDA » PandaRoot » Bugs, Fixes, Releases » CbmTrackPar bug?

Show: Today's Messages :: Polls :: Message Navigator

CbmTrackPar bug? [message #4691]

Wed, 18 July 2007 17:36

StefanoSpataro
Messages: 2736
Registered: June 2005
Location: Torino

first-grade participant

From: *physik.uni-giessen.de

Hello,
i found something strange in the trackbase/CbmtrackPar.cxx.

Here you are the main constructor:

// ----- Constructor with parameters -----------------------------------
CbmTrackPar::CbmTrackPar(Double_t x, Double_t y, Double_t z,
Double_t px, Double_t py, Double_t pz, Double_t q)
{
fX = 0;
fY = 0;
fZ = 0;
fPx = 0;
fPy = 0;
fPz = 0;
fq= q;
Double_t p=TMath::Sqrt(fPx*fPx +fPy*fPy +fPz*fPz );
if (p!=0)fQp = q/p;
else fQp=0;
}

Should it be:

fX = x;
fY = y;
fZ = z;
fPx = px;
fPy = py;
fPz = pz;

or am I missing something?

Report message to a moderator

Re: CbmTrackPar bug? [message #4693 is a reply to message #4691]

Wed, 18 July 2007 17:53

Andrea Fontana
Messages: 32
Registered: May 2007

continuous participant

From: *pv.infn.it

Ciao Stefano,
yes, you are right, but this constructor is never called.
The working class is CbmTrackParH and here all the variables
are loaded correctly.
We will fix this anyway!

Ciao,
Andrea

Report message to a moderator

Re: CbmTrackPar bug? [message #4694 is a reply to message #4693]

Wed, 18 July 2007 17:58

StefanoSpataro
Messages: 2736
Registered: June 2005
Location: Torino

first-grade participant

From: *physik.uni-giessen.de

Well,
CbmTrackParH des not use that constructor, but this is not the case for CbmTrackParP:

CbmTrackParP.cxx
CbmTrackParP::CbmTrackParP(Double_t x, Double_t y, Double_t z,
Double_t tx, Double_t ty, Double_t qp,
Double_t CovMatrix[15])
: CbmTrackPar(x,y,z,0,0,0,0)
{
etc...
}

I already fixed it in my local version of the code, I could put it in svn if needed.
Bye

Ste

Report message to a moderator

Re: CbmTrackPar bug? [message #4695 is a reply to message #4693]

Wed, 18 July 2007 18:01

Ralf Kliemt
Messages: 507
Registered: May 2007
Location: GSI, Darmstadt

first-grade participant

From: 141.30.85*

Ciao Andrea,

I noticed that your update of the trackbase package contains a new class CbmGeaneUtil. However its compilation call in the CMakeLists.txt is missing (you updated only the Makefile.am and the TrackBaseLingDef.h). It compiles with cmake, but this class is missing, which will cause some problems at runtime.

Kind regards, Ralf.

Report message to a moderator