GSI Forum: Bugs, Fixes, Releases » [FIXED] FairWriteoutBuffer::FillNewData and object ownership (memory leak)

Home » PANDA » PandaRoot » Bugs, Fixes, Releases » [FIXED] FairWriteoutBuffer::FillNewData and object ownership (memory leak)

Show: Today's Messages :: Polls :: Message Navigator

Re: FairWriteoutBuffer::FillNewData and object ownership (memory leak) [message #14415 is a reply to message #14414]

Thu, 31 January 2013 14:24

Oliver Merle
Messages: 13
Registered: December 2010

occasional visitor

From: *wlan.uni-giessen.de

Thank you, Tobias.

Just as an opinion: the most elegant way - from the beginning - would have been to design FairWriteoutBuffer as a template FairWriteoutBuffer<t_digit, t_modify_functor > which is derived from base FairWriteoutBufferBase (<=> your current FairWriteoutBuffer). This way the compiler would autogenerate the boilerplate code which users currently have to implement. The only class the user would have to add is a custom modify functor in case he needs one.

The digit at the user side would be allocated on the stack and passed as const t_digit & (-> no new, no leak). This would decouple user and framework code so that you never run into these ownership problems.

Nevertheless, it doesn't hurt much to add the classes by hand. I mean ... you don't want to sell this package and scientists aren't too picky when it comes to copy and paste Wink

Report message to a moderator

[Message index]

		[FIXED] FairWriteoutBuffer::FillNewData and object ownership (memory leak) By: Oliver Merle on Fri, 18 January 2013 23:03
		Re: FairWriteoutBuffer::FillNewData and object ownership (memory leak) By: Oliver Merle on Sat, 26 January 2013 14:31
		Re: FairWriteoutBuffer::FillNewData and object ownership (memory leak) By: Mohammad Al-Turany on Sat, 26 January 2013 16:33
		Re: FairWriteoutBuffer::FillNewData and object ownership (memory leak) By: Oliver Merle on Sat, 26 January 2013 17:39
		Re: FairWriteoutBuffer::FillNewData and object ownership (memory leak) By: Mohammad Al-Turany on Sat, 26 January 2013 19:37
		Re: FairWriteoutBuffer::FillNewData and object ownership (memory leak) By: Oliver Merle on Sat, 26 January 2013 22:00
		Re: FairWriteoutBuffer::FillNewData and object ownership (memory leak) By: Tobias Stockmanns on Mon, 28 January 2013 14:02
		Re: FairWriteoutBuffer::FillNewData and object ownership (memory leak) By: Tobias Stockmanns on Wed, 30 January 2013 17:43
		Re: FairWriteoutBuffer::FillNewData and object ownership (memory leak) By: Oliver Merle on Thu, 31 January 2013 14:24
		Re: FairWriteoutBuffer::FillNewData and object ownership (memory leak) By: Tobias Stockmanns on Thu, 31 January 2013 15:36
		Re: FairWriteoutBuffer::FillNewData and object ownership (memory leak) By: Oliver Merle on Fri, 01 February 2013 00:58
		Re: FairWriteoutBuffer::FillNewData and object ownership (memory leak) By: Tobias Stockmanns on Fri, 01 February 2013 10:08
		Re: FairWriteoutBuffer::FillNewData and object ownership (memory leak) By: Philipp Mahlberg on Mon, 25 February 2013 16:46

Previous Topic:	[FIXED] magnet geometry simulation problem
Next Topic:	[WONTFIX] sep12 external package crash during installation on fedora 18

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Fri May 29 21:28:07 CEST 2026

Total time taken to generate the page: 0.01284 seconds